Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#912 - Quadratic map of a zonotope #2218

Merged
merged 15 commits into from Jul 29, 2020
Merged

#912 - Quadratic map of a zonotope #2218

merged 15 commits into from Jul 29, 2020

Conversation

SebastianGuadalupe
Copy link
Member

Closes #912.

src/Sets/Zonotope.jl Outdated Show resolved Hide resolved
src/Sets/Zonotope.jl Outdated Show resolved Hide resolved
src/Sets/Zonotope.jl Outdated Show resolved Hide resolved
src/Sets/Zonotope.jl Outdated Show resolved Hide resolved
src/Sets/Zonotope.jl Outdated Show resolved Hide resolved
src/Sets/Zonotope.jl Outdated Show resolved Hide resolved
src/Sets/Zonotope.jl Outdated Show resolved Hide resolved
SebastianGuadalupe and others added 5 commits July 28, 2020 12:26
Co-authored-by: Christian Schilling <christian.schilling@ist.ac.at>
Co-authored-by: Christian Schilling <christian.schilling@ist.ac.at>
src/Sets/Zonotope.jl Outdated Show resolved Hide resolved
src/Sets/Zonotope.jl Outdated Show resolved Hide resolved
Copy link
Member

@mforets mforets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🎉

tests for the new function are missing

src/Sets/Zonotope.jl Outdated Show resolved Hide resolved
src/Sets/Zonotope.jl Outdated Show resolved Hide resolved
SebastianGuadalupe and others added 2 commits July 29, 2020 09:57
Co-authored-by: Marcelo Forets <mforets@gmail.com>
Co-authored-by: Marcelo Forets <mforets@gmail.com>
@mforets mforets changed the title WIP #912 - Quadratic map of a zonotope #912 - Quadratic map of a zonotope Jul 29, 2020
@SebastianGuadalupe
Copy link
Member Author

When using the function it returns zero generators and some repeated generators, here is an example:

N = Float64
Z = Zonotope(N[0, 0], N[1 0; 0 1])
Q1 = N[1/2 0; 0 1/2]
Q2 = N[0 1/2; 1/2 0]
genmat(quadratic_map([Q1, Q2], Z))

2×5 Array{Float64,2}:
 0.0  0.0  0.25  0.25  0.0
 0.0  0.0  0.0   0.0   1.0

src/Sets/Zonotope.jl Outdated Show resolved Hide resolved
src/Sets/Zonotope.jl Outdated Show resolved Hide resolved
@mforets mforets mentioned this pull request Jul 29, 2020
src/Sets/Zonotope.jl Outdated Show resolved Hide resolved
@mforets mforets merged commit bf842a5 into master Jul 29, 2020
@mforets mforets deleted the sguadalupe/912 branch July 29, 2020 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quadratic map of a zonotope
3 participants