#2778 - Simplify code in 2D minkowski_sum #3327
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2778.
This PR removes the workaround for the "unreachable reached" Julia bug (which is still around). The solution is to just use a different dispatch. For that the method
_minkowski_sum_vrep_2d
had to be changed. It tried to be generic inVT
but was not. The vectorR
was filled withVector{N}
s, so unlessVT
wasVector{N}
(or a supertype likeAbstractVector{N}
, but that would be strange), the code would crash.