#731 - Constraints list of Ball1 #735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schillic
approved these changes
Oct 7, 2018
src/Ball1.jl
Outdated
| clist = Vector{LinearConstraint{N}}(undef) | ||
| sizehint!(clist, 2^n) | ||
| for (i, di) in enumerate(Iterators.product([[one(N), -one(N)] for i = 1:n]...)) | ||
| di = collect(di) # tuple -> vector |
There was a problem hiding this comment.
Generally one should not redefine variables with new types for type stability.
There was a problem hiding this comment.
i added because i was getting MethodError no method matching dot(::Tuple, ::Array). i don't know if it can be done in a different way, seems like Iterators.product... is always returning tuples.
There was a problem hiding this comment.
I meant to use a new variable name.
There was a problem hiding this comment.
Okay thanks, this was more a general remark, not meant to be fixed, but 👍
|
You could have just removed the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #731.