Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow-up of @system macro #133

Open
3 of 12 tasks
mforets opened this issue Jan 23, 2020 · 3 comments
Open
3 of 12 tasks

Follow-up of @system macro #133

mforets opened this issue Jan 23, 2020 · 3 comments
Labels

Comments

@mforets
Copy link
Member

mforets commented Jan 23, 2020

Originally posted by @ueliwechsler in #125 (comment)

The following things can be done in a later PR (in approximately increasing order of work needed):

@ueliwechsler
Copy link
Collaborator

ueliwechsler commented Jan 29, 2020

from #137:

  • allow property initial_state as state(0) ∈ set to create IVP

@ueliwechsler
Copy link
Collaborator

ueliwechsler commented Jan 31, 2020

from #139

  • consistent type conversion in x' = -x and x' = 2x

@ueliwechsler
Copy link
Collaborator

ueliwechsler commented Feb 4, 2020

Additionally, we should try to remove the explicit dependency on MathematicalSystems in these lines

push!(params, (:(IdentityMultiple(1.0*MathematicalSystems.I,$state_dim)), :B))

push!(params, (:(IdentityMultiple(1.0*MathematicalSystems.I,$state_dim)), :D))

by writing push!(params, I($state_dim), :B) or something similar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants