Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle arbitrary order of set / rhs term specifcation in @system #176

Merged
merged 13 commits into from
Feb 21, 2020

Conversation

ueliwechsler
Copy link
Collaborator

Closes an element of #133

The order of the set specification can be arbitrary now.

Additionally, it allows for arbitrary order of rhs term specification in the dynamic equation.

See test for an example.

@mforets mforets mentioned this pull request Feb 18, 2020
12 tasks
src/macros.jl Outdated Show resolved Hide resolved
src/macros.jl Outdated Show resolved Hide resolved
src/macros.jl Outdated Show resolved Hide resolved
src/macros.jl Outdated Show resolved Hide resolved
ueliwechsler and others added 2 commits February 18, 2020 21:02
Co-Authored-By: Christian Schilling <schillic@informatik.uni-freiburg.de>
Copy link
Member

@mforets mforets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far! I left some comments.

src/macros.jl Show resolved Hide resolved
src/macros.jl Outdated Show resolved Hide resolved
src/macros.jl Show resolved Hide resolved
src/macros.jl Show resolved Hide resolved
src/macros.jl Show resolved Hide resolved
src/macros.jl Outdated Show resolved Hide resolved
src/macros.jl Outdated Show resolved Hide resolved
src/macros.jl Outdated Show resolved Hide resolved
src/macros.jl Outdated Show resolved Hide resolved
mforets and others added 5 commits February 21, 2020 11:30
Co-Authored-By: Christian Schilling <schillic@informatik.uni-freiburg.de>
Co-Authored-By: Christian Schilling <schillic@informatik.uni-freiburg.de>
Co-Authored-By: Christian Schilling <schillic@informatik.uni-freiburg.de>
Co-Authored-By: Christian Schilling <schillic@informatik.uni-freiburg.de>
Copy link
Member

@mforets mforets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mforets mforets merged commit 02547bd into master Feb 21, 2020
@ueliwechsler ueliwechsler deleted the ueliwechsler/133_setorder branch March 14, 2020 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants