Revise SimulationSolution #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mforets
approved these changes
Mar 6, 2021
|
@SebastianGuadalupe this changeset might be relevant to you. Let me know if you have comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did a mistake in #108: The struct did not wrap a single simulation as intended but rather the results for one control cycle. I think it is more reasonable to instead store everything related to a single simulation in a
SimulationSolution. (And some of the functions were not exported.)Since there is currently no plot recipe for the
SimulationSolution(#110),plotadds a new label for each trajectory now and plotting the simulation pieces recenters the picture. The second commit fixes these issues in the (currently only) model script that plots simulations.