Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix optional packages in Exponentiation module #770

Merged
merged 2 commits into from
Feb 9, 2024
Merged

Conversation

schillic
Copy link
Member

@schillic schillic commented Feb 4, 2024

  • fix the warning below, which required to load the init function inside the Exponentiation module
    • comment out _expv because it was not used anywhere
WARNING: Method definition _exp(SparseArrays.SparseMatrixCSC{Tv, Ti} where
Ti<:Integer where Tv, ReachabilityAnalysis.Exponentiation.PadeExpAlg) in module Exponentiation at
/home/runner/work/ReachabilityAnalysis.jl/ReachabilityAnalysis.jl/src/Discretization/Exponentiation.jl:139
overwritten in module ReachabilityAnalysis at
/home/runner/work/ReachabilityAnalysis.jl/ReachabilityAnalysis.jl/src/Discretization/Exponentiation.jl:143.
  • change require(@__MODULE__, Expokit) to the correct form require(@__MODULE__, :Expokit)
  • remove FastExpm because it was not used anywhere

@schillic schillic merged commit 5cbf157 into master Feb 9, 2024
6 checks passed
@schillic schillic deleted the schillic/init branch February 9, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants