Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove basetype (available in ReachabilityBase) #831

Merged
merged 1 commit into from
Jun 1, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion docs/src/lib/flowpipes.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ AbstractFlowpipe
The following functions are available at the interface level.

```@docs
basetype(::Type{<:AbstractFlowpipe})
LazySets.ρ(::AbstractVector, ::AbstractFlowpipe)
LazySets.σ(::AbstractVector, ::AbstractFlowpipe)
LazySets.dim(::AbstractFlowpipe)
Expand Down
8 changes: 0 additions & 8 deletions docs/src/lib/internals.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,3 @@ Depth = 3
```@docs
_default_cpost
```

## Documentation fixes

The following duplicated documentation is necessary due to a problem in the `Documenter` package.

```@docs
basetype
```
1 change: 0 additions & 1 deletion docs/src/lib/reachsets.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ AbstractReachSet
The functions are available at the interface level.

```@docs
basetype(::Type{<:AbstractReachSet})
set(::AbstractReachSet)
setrep(::AbstractReachSet)
tspan(::AbstractReachSet)
Expand Down
16 changes: 0 additions & 16 deletions src/Flowpipes/AbstractFlowpipe.jl
Original file line number Diff line number Diff line change
Expand Up @@ -13,22 +13,6 @@ A flowpipe is the set union of an array of reach-sets.
"""
abstract type AbstractFlowpipe end

"""
basetype(T::Type{<:AbstractFlowpipe})

Return the base type of the given flowpipe type (i.e., without type parameters).

### Input

- `T` -- flowpipe type, used for dispatch

### Output

The base type of `T`.
"""
basetype(T::Type{<:AbstractFlowpipe}) = Base.typename(T).wrapper
basetype(fp::AbstractFlowpipe) = basetype(typeof(fp))

# LazySets interface: fallback behaves like UnionSetArray

"""
Expand Down
15 changes: 0 additions & 15 deletions src/ReachSets/AbstractReachSet.jl
Original file line number Diff line number Diff line change
Expand Up @@ -37,21 +37,6 @@ abstract type AbstractReachSet{N} end
const SetOrReachSet = Union{LazySet,UnionSet,UnionSetArray,IA.Interval,IA.IntervalBox,
AbstractReachSet}

"""
basetype(T::Type{<:AbstractReachSet})

Return the base type of the given reach-set type (i.e., without type parameters).

### Input

- `T` -- reach-set type, used for dispatch

### Output

The base type of `T`.
"""
basetype(T::Type{<:AbstractReachSet}) = Base.typename(T).wrapper

"""
set(R::AbstractReachSet)

Expand Down
1 change: 0 additions & 1 deletion test/flowpipes/flowpipes.jl
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ using ReachabilityAnalysis: _isapprox

# base, numeric, set and reach-set types
FT = typeof(fp)
@test basetype(FT) == basetype(fp) == Flowpipe
N = ReachabilityAnalysis.numtype(fp)
@test N == Float64
ZT = Zonotope{N,Vector{N},Matrix{N}}
Expand Down
Loading