Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

about missing Deps.toml file for the package #23

Closed
wookay opened this issue Jan 3, 2019 · 6 comments
Closed

about missing Deps.toml file for the package #23

wookay opened this issue Jan 3, 2019 · 6 comments

Comments

@wookay
Copy link

wookay commented Jan 3, 2019

Hello, just registered a package and now it has automatic sync with METADATA.

The package contains Project.toml with

[deps]
Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"

but in the following registry doesn't have the Deps.toml file for that package.
https://github.com/JuliaRegistries/General/tree/master/J/Jive

Compat.toml
Package.toml
Versions.toml

I don't know how could I make the Deps.toml file.
It's best appreciate for any hint.
thanks.

@StefanKarpinski
Copy link
Contributor

The only released version of Jive doesn't have any dependencies:

https://github.com/JuliaLang/METADATA.jl/blob/metadata-v2/Jive/versions/0.1.0/requires

If you want Test in the Deps.toml file, you need it in the REQUIRE file. Currently, the project's Project.toml file is ignored and what's registered in METADATA is the source of truth, which is based on the REQUIRE file not the Project.toml file.

@wookay
Copy link
Author

wookay commented Jan 3, 2019

thank you very much!

@wookay
Copy link
Author

wookay commented Jan 3, 2019

I'm sorry to bother it again,
when I added Test to the REQUIRE file, I got failed on travis-ci for METADATA.jl.

https://travis-ci.org/JuliaLang/METADATA.jl/jobs/474972602#L506

ERROR: LoadError: package Jive v0.1.1 requires a non-registered package: Test
Stacktrace:
 [1] check_metadata(::Set{String}) at /home/travis/build/JuliaLang/METADATA.jl/.test/METADATA.jl:266
 [2] check_metadata() at /home/travis/build/JuliaLang/METADATA.jl/.test/METADATA.jl:262
 [3] top-level scope at none:0
 [4] include at ./boot.jl:317 [inlined]
 [5] include_relative(::Module, ::String) at ./loading.jl:1044
 [6] include(::Module, ::String) at ./sysimg.jl:29
 [7] include(::String) at ./client.jl:392
 [8] top-level scope at none:0
in expression starting at /home/travis/build/JuliaLang/METADATA.jl/.test/METADATA.jl:279
The command "sh .test/ci.sh" exited with 1.

@StefanKarpinski
Copy link
Contributor

Ah yes, sorry, since Test is a stdlib you can't depend on it in REQUIRE. The sync script uses a regular expression to detect stdlib dependencies, I'm not sure why it's picking this one up.

@StefanKarpinski
Copy link
Contributor

This was actually a bug in the registry sync script. It's fixed now. Sorry for the trouble and thanks for bringing it to my attention!

bors bot added a commit to JuliaLang/Pkg.jl that referenced this issue Jan 4, 2019
982:  bug fixes to bin/gitmeta.jl r=StefanKarpinski a=StefanKarpinski

Fixes JuliaRegistries/General#23.

Co-authored-by: Stefan Karpinski <stefan@karpinski.org>
@wookay
Copy link
Author

wookay commented Jan 4, 2019

your welcome! I'm closing the issue with happy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants