Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uncap StatsBase dependencies from 0.29 to 0.* #256

Merged
merged 1 commit into from Apr 24, 2019

Conversation

StefanKarpinski
Copy link
Contributor

@StefanKarpinski StefanKarpinski commented Apr 24, 2019

This changes the compat range for all packages that depend on StatsBase that were capped at 0.29, assuming that this cap was introduced by the switch from METADATA to General and that they should continue to be compatible with all 0.x versions of StatsBase for now.

@StefanKarpinski
Copy link
Contributor Author

cc @nalimilan, @KristofferC

@nalimilan
Copy link
Contributor

Sounds reasonable for now, though of course some packages may not fully work with StatsBase 0.30.0 (e.g. GLM fails its tests because of a small change, which doesn't affect 99% of uses though). There's no ideal solution except stabilizing the API and running automated tests for each breaking release.

@StefanKarpinski
Copy link
Contributor Author

So I should merge?

@StefanKarpinski StefanKarpinski merged commit f8a1bf0 into master Apr 24, 2019
@StefanKarpinski StefanKarpinski deleted the sk/uncap-StatsBase branch April 24, 2019 17:18
@nalimilan
Copy link
Contributor

I guess we should also do the same thing to all packages whose upper cap was increased from 0.29 to 0.30 by #227?

@StefanKarpinski
Copy link
Contributor Author

StefanKarpinski commented Apr 25, 2019

Those were already "uncapped" by the new normalization scheme, which considers all 0.x versions compatible and therefore renders a concrete upper bound of 0.30 in the absence of any 0.31 version of StatsBase as a 0.* upper bound. On the flip side, if and when a 0.x release is made that is actually incompatible and breaks dependencies, they will all have to change their caps, but that is the sour fruit of pretending that 0.x releases are non-breaking.

@nalimilan
Copy link
Contributor

OK, cool. So what's the recommendation now for compat in Project.toml files? Use >= X.Y.Z for all dependencies that still haven't reached 1.0?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants