Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version: ForneyLab v0.11.3 #40350

Merged
merged 1 commit into from
Jul 22, 2021
Merged

Conversation

JuliaRegistrator
Copy link
Contributor

@JuliaRegistrator JuliaRegistrator commented Jul 6, 2021

JuliaRegistrator referenced this pull request in biaslab/ForneyLab.jl Jul 6, 2021
update(): Update Project.toml to satisfy Julia General registry auto-merge requirements
@JuliaRegistrator JuliaRegistrator temporarily deployed to stopwatch July 6, 2021 12:25 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2021

Your new version pull request met all of the guidelines for auto-merging and is scheduled to be merged in the next round.


If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment.

@albertpod
Copy link
Contributor

Could you please merge this PR manually. We have theLicence.mdfile, however, the bot doesn't recognize it.
The previous PR#40345 can be removed.

@simeonschaub
Copy link
Contributor

This license seems quite restrictive and is certainly not OSI-approved. See https://github.com/JuliaRegistries/General#registering-a-package-in-general.

@albertpod
Copy link
Contributor

@simeonschaub this package exists with this license for quite some time and there was no issue previously.

@simeonschaub
Copy link
Contributor

simeonschaub commented Jul 6, 2021

Yes, you are free to license your own work however you want and it is great that you want to make it available to other people! Please understand though that the General registry is maintained by the community and is meant for open-source packages. Since the Julia community does not have the resources to double-check the legal implications of every license out there, this means that only licenses approved by the OSI are accepted in the General registry.

@bvdmitri
Copy link
Contributor

bvdmitri commented Jul 6, 2021

@simeonschaub Thanks for helping us. This package exists in Julia registry for years already and initially has been registered in 2018. This is just a minor release to bump [compat] section to be compatible with new versions of other packages. The package is well known by the Bayesian inference community and we also presented it on JuliaCon. How should we proceed and why our license became an issue only now? We would prefer to keep things as they are and we do not really want to change our license for a minor fix.

@giordano
Copy link
Member

giordano commented Jul 6, 2021

How should we proceed

If you're unwilling to change the license to have an OSI-approved one, we won't accept any new versions. At the moment we don't plan to remove from the registry packages which don't comply with this rule, but this may change in the future.

why our license became an issue only now?

Because we started actually checking the license only recently: https://discourse.julialang.org/t/fyi-the-general-registry-now-checks-for-an-osi-approved-software-license-when-registering-new-packages-and-new-versions/57018. As explained there, the rule is actually very old but we never automatically enforced it until recently.

@DilumAluthge
Copy link
Member

I notice that some newer packages from your group (e.g. https://github.com/biaslab/ReactiveMP.jl/blob/master/LICENSE) have the MIT license.

Would you be willing to also re-license this package under the MIT license?

@DilumAluthge
Copy link
Member

As explained there, the rule is actually very old but we never automatically enforced it until recently.

To elaborate on this, this rule goes back to the days of METADATA.jl (the precursor to General). It was originally added in JuliaLang/METADATA.jl#3788 in October 2015.

@bvdmitri
Copy link
Contributor

bvdmitri commented Jul 8, 2021

Hey @DilumAluthge, thanks for these links! We are discussing possible solutions and will return to this PR later.

UUID: 9fc3f58a-c2cc-5bff-9419-6a294fefdca9
Repo: https://github.com/biaslab/ForneyLab.jl.git
Tree: 68db94dc8d00b01b86bd8783439bf60da5504c8b

Registrator tree SHA: c7e033175c3b9b466fb2cc8beab47042878a66b0
@JuliaRegistrator JuliaRegistrator force-pushed the registrator/forneylab/9fc3f58a/v0.11.3 branch from 45a2807 to 8ff43b6 Compare July 22, 2021 14:35
JuliaRegistrator referenced this pull request in biaslab/ForneyLab.jl Jul 22, 2021
Migrate from TravisCI to GitHub Actions
@JuliaRegistrator JuliaRegistrator temporarily deployed to stopwatch July 22, 2021 14:35 Inactive
@bvdmitri
Copy link
Contributor

@DilumAluthge @simeonschaub @giordano
Thanks for your help!
We have changed the license for the package and all checks have passed. Could you please manually merge this PR?

@giordano giordano merged commit cd41ec0 into master Jul 22, 2021
@giordano giordano deleted the registrator/forneylab/9fc3f58a/v0.11.3 branch July 22, 2021 15:03
@giordano
Copy link
Member

Great, thanks!

@DilumAluthge
Copy link
Member

Thank you @bvdmitri and everyone that helped out in this thread!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants