-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New package: mlpack v3.2.3 #9767
Conversation
JuliaRegistrator
commented
Feb 19, 2020
•
edited
Loading
edited
- Registering package: mlpack
- Repository: https://github.com/mlpack/mlpack.jl
- Created by: @rcurtin
- Version: v3.2.3
- Commit: e0c6f2678a782aac60c34da02bb076c0578a617f
- Git reference: master
- Release notes:
Your
Note that the guidelines are only required for the pull request to be merged automatically. However, it is strongly recommended to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human. Since you are registering a new package, please make sure that you have read the package naming guidelines: https://julialang.github.io/Pkg.jl/dev/creating-packages/#Package-naming-guidelines-1 If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text |
Right, we've broken the guidelines. But I think we have good reason. :)
I believe I've solved the compat issue, but I'm not sure how to get @JuliaRegistrator to rebuild the package. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this should be merged with the current name. To quote @davidanthoff in Slack:
There are lots of Julia packages that wrap some upstream package that uses some capitalization that doesn't conform with the Julia norm, and the practice for the Julia package has been to adhere to the Julia convention.
So I don't see a reason to make an exception here, to be honest 🙂
That summarizes my thoughts here exactly.
It seems perfectly fine to me for the name of a JLL to match the name of the library that it wraps. That's exactly what I did with bsdiff. |
Thanks to @ericphanson in mlpack/mlpack.jl#2, the upper bound on the compat entry is added now. I'm not sure if I need to do anything to make an automatic rebuild happen, but I'm happy to handle anything else if needed. 👍 |
Retrigger Registrator. This will update the PR. |
This isn't a JLL registration |
@DilumAluthge I can see how to retrigger if I used the GitHub App, but I used the web registrator at https://pkg.julialang.org/registrator/, so the instructions here don't seem to apply. Does the web registrator automatically update a PR if one is already open? I don't want to accidentally open a different one if I don't need to. 👍 |
Yeah it should update this PR. Try it out. If it makes a duplicate for some reason, we can close one of the PRs, no big deal. |
6c0db90
to
7439e62
Compare
Victory, thank you @DilumAluthge! 👍 |
UUID: cf18a64e-e90e-11e8-37b7-fb5df6478bc0 Repo: https://github.com/mlpack/mlpack.jl.git Tree: 7844ffb9a515fac525eba2ffe01bf45b90ff1d0d Registrator tree SHA: f50e50c1d2a1b9694b1d5749fdb25fef2ca4c291
7439e62
to
0408b2f
Compare
Alright, looks like everything is okay after the rebuild. 👍 |
As Alex pointed out, this is a regular Julia package (JLLs are as well but..), and |
Ultimately the choice of package name is up to the author. We can make recommendations, but as long as they pick a name that isn't clearly typosquatting or offensive, it's up to them. |
It seems clear to me that the author wants this name, and neither of the two criteria in Stefan’s comment are met. |
Thanks all, much appreciated. 👍 |