Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If a non-JLL package has a JLL package as a dependency, we will not require you to have a compat entry for the JLL package #148

Merged
merged 1 commit into from
Dec 26, 2019

Conversation

DilumAluthge
Copy link
Member

If a non-JLL package has a JLL package as a dependency, we will not require you to have a compat entry for the JLL package.

E.g. suppose you have a package Example.jl. And Example.jl has a dependency Foo_jll.jl. We will not require that Example.jl has a compat entry for Foo_jll.jl.

…equire you to have a compat entry for the JLL package
@codecov
Copy link

codecov bot commented Dec 26, 2019

Codecov Report

Merging #148 into master will decrease coverage by 0.09%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #148     +/-   ##
=========================================
- Coverage   59.84%   59.75%   -0.1%     
=========================================
  Files          16       17      +1     
  Lines         660      661      +1     
=========================================
  Hits          395      395             
- Misses        265      266      +1
Impacted Files Coverage Δ
src/AutoMerge/guidelines.jl 65.26% <0%> (ø) ⬆️
src/AutoMerge/jll.jl 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a453a15...6521e5d. Read the comment docs.

@DilumAluthge DilumAluthge merged commit c184692 into master Dec 26, 2019
@DilumAluthge DilumAluthge deleted the da/jll-compat branch December 26, 2019 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant