Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Pkg.add("Foo") and import Foo two different steps #151

Merged
merged 10 commits into from
Dec 27, 2019

Conversation

DilumAluthge
Copy link
Member

Fixes #114

@codecov
Copy link

codecov bot commented Dec 27, 2019

Codecov Report

Merging #151 into master will increase coverage by 0.89%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #151      +/-   ##
==========================================
+ Coverage   59.93%   60.83%   +0.89%     
==========================================
  Files          17       17              
  Lines         659      674      +15     
==========================================
+ Hits          395      410      +15     
  Misses        264      264
Impacted Files Coverage Δ
src/AutoMerge/new-package.jl 75% <100%> (+1.08%) ⬆️
src/AutoMerge/new-version.jl 71.11% <100%> (+1.34%) ⬆️
src/AutoMerge/guidelines.jl 68.86% <100%> (+3.6%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b846dd0...e60d332. Read the comment docs.

@DilumAluthge DilumAluthge merged commit 26f238f into master Dec 27, 2019
@DilumAluthge DilumAluthge deleted the da/two-different-checks branch December 27, 2019 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pkg.add("Foo") and import Foo should be two different checks
1 participant