Thoroughly nospecialize all functions; add no-alloc, no-specialize test. #14
+64
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NHDaly
force-pushed
the
nhd-nospecialize-2
branch
from
d82675e
to
043150c
Compare
NHDaly
force-pushed
the
nhd-nospecialize-2
branch
from
043150c
to
3487afa
Compare
Make sure that _all_ functions in ExceptionUnwrapping are marked nospecialize. We don't want to pay the wasted compilation time at runtime, since these are all going to be called in _exceptional_ cases, certainly not in a hot loop, and because we've seen crashes caused by a stackoverflow in type inference while attempting to specialize the code to handle a StackOverflowException! 😅 This time, we add a unit test to ensure that that these functions do not allocate and do not incur new compilation when called with novel arguments.
NHDaly
force-pushed
the
nhd-nospecialize-2
branch
from
3487afa
to
e50a8d0
Compare
Drvi
reviewed
Jun 28, 2023
Comment on lines
+116
to
+118
| @show exc | ||
| @show is_wrapped_exception(exc) | ||
| global EXC = exc |
There was a problem hiding this comment.
I think this is a leftover from debugging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure that all functions in ExceptionUnwrapping are marked nospecialize. We don't want to pay the wasted compilation time at runtime, since these are all going to be called in exceptional cases, certainly not in a hot loop, and because we've seen crashes caused by a stackoverflow in type inference while attempting to specialize the code to handle a StackOverflowException! 😅
This time, we add a unit test to ensure that that these functions do not allocate and do not incur new compilation when called with novel arguments.
This is a follow-up to #6 and #15.