Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add amd, colamd and symamd methods for Hermitian wrapper #51

Merged
merged 2 commits into from
Apr 21, 2022

Conversation

amontoison
Copy link
Member

@amontoison amontoison commented Apr 21, 2022

We will need it for LDLFactorizations.jl if we want to solve complex linear systems.

@codecov
Copy link

codecov bot commented Apr 21, 2022

Codecov Report

Merging #51 (8273e71) into main (a817fbf) will decrease coverage by 1.26%.
The diff coverage is 60.00%.

@@            Coverage Diff             @@
##             main      #51      +/-   ##
==========================================
- Coverage   95.20%   93.93%   -1.27%     
==========================================
  Files           3        3              
  Lines         125      132       +7     
==========================================
+ Hits          119      124       +5     
- Misses          6        8       +2     
Impacted Files Coverage Δ
src/AMD.jl 93.65% <50.00%> (-3.02%) ⬇️
src/COLAMD.jl 92.30% <66.66%> (+0.64%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a817fbf...8273e71. Read the comment docs.

Copy link
Member

@dpo dpo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thank you!

@dpo dpo merged commit 141e894 into JuliaSmoothOptimizers:main Apr 21, 2022
@amontoison amontoison deleted the hermitian branch April 21, 2022 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants