Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for specialized interface #26

Conversation

abelsiqueira
Copy link
Member

This implements the tests for the specialized interface. The same functions tested with the core interface are tested here.

This was built on top of the PR #24.

I think now I'm gonna try to implement the TRON method we discussed before.

@eval ccall(("cutest_udimen_", $(libname)), Void,
(Ptr{Cint}, Ptr{Cint}, Ptr{Cint}),
$(io_err), $(input), $(n))
end

function udimsh(io_err::Array{Cint, 1}, nnzh::Array{Cint, 1}, libname = fixedlibname)
function udimsh(io_err::Array{Cint, 1}, nnzh::Array{Cint, 1}, libname
= fixedlibname)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to introduce a line break like this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This, and others, happened because I changed some things in the script. In this case, the line wrapper. I'll fix it.

@dpo
Copy link
Member

dpo commented Jul 24, 2015

Should we close #24 then?

@abelsiqueira
Copy link
Member Author

#24 closed.

@abelsiqueira
Copy link
Member Author

Commit 1b97091 removes the changes in the script. File src/core_interface.jl is unmodified.

@abelsiqueira
Copy link
Member Author

About the multiple dispatch, I tested locally and it works. Also, we are currently not exporting the functions from core. CUTEst.ufn if from core and ufn is from the specialized. Should we export them too?

@dpo
Copy link
Member

dpo commented Jul 26, 2015

Yes I guess we should export all interfaces.

@abelsiqueira
Copy link
Member Author

Updated the names and the export.

@abelsiqueira
Copy link
Member Author

@dpo, do I need to rebase this, or you want to merge manually?

@dpo
Copy link
Member

dpo commented Aug 3, 2015

Sorry I haven't gotten to this yet. It would be great if you could rebase, if you don't mind. Thanks!

Now, the core interface does not use a default libname.
Also, in the specialized interface, either nlp or libname is required
When the input is an array of integers, it can be either an array of
Int or of Cint (Int32). The first case needs to be copied, the second
can be passed directly to the core interface call.
@abelsiqueira
Copy link
Member Author

@dpo I refactored this PR into PR #33. It's easier to read, and cleaner. I'm closing this, but I'll wait until you merge #33 to delete this branch, in case you want to check individual commits.

@abelsiqueira abelsiqueira deleted the feat/test-creation-script branch August 4, 2015 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants