-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests for specialized interface #26
Tests for specialized interface #26
Conversation
@eval ccall(("cutest_udimen_", $(libname)), Void, | ||
(Ptr{Cint}, Ptr{Cint}, Ptr{Cint}), | ||
$(io_err), $(input), $(n)) | ||
end | ||
|
||
function udimsh(io_err::Array{Cint, 1}, nnzh::Array{Cint, 1}, libname = fixedlibname) | ||
function udimsh(io_err::Array{Cint, 1}, nnzh::Array{Cint, 1}, libname | ||
= fixedlibname) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you mean to introduce a line break like this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This, and others, happened because I changed some things in the script. In this case, the line wrapper. I'll fix it.
Should we close #24 then? |
#24 closed. |
Commit 1b97091 removes the changes in the script. File |
About the multiple dispatch, I tested locally and it works. Also, we are currently not exporting the functions from core. |
Yes I guess we should export all interfaces. |
Updated the names and the export. |
@dpo, do I need to rebase this, or you want to merge manually? |
Sorry I haven't gotten to this yet. It would be great if you could rebase, if you don't mind. Thanks! |
Separate the interface generation into functions, and implement specialized function with easier syntax.
The core interface needs an array of Cints.
Some text wrapping call changed from the last script so the line break happened in other places. In short, using "("+wrap(...)+")" instead of wrap("(...)")
a551809
to
c0c6808
Compare
Now, the core interface does not use a default libname. Also, in the specialized interface, either nlp or libname is required
When the input is an array of integers, it can be either an array of Int or of Cint (Int32). The first case needs to be copied, the second can be passed directly to the core interface call.
This implements the tests for the specialized interface. The same functions tested with the core interface are tested here.
This was built on top of the PR #24.
I think now I'm gonna try to implement the TRON method we discussed before.