Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In-place version #58

Merged
merged 4 commits into from
Aug 25, 2022
Merged

Conversation

geoffroyleconte
Copy link
Member

All the elements of adiag should keep their sign.

LLDL.L now allocates in order to keep the existing behaviour but I can change it to something like

get_L_factor(LLDL) = ...

if that is an issue.

@codecov
Copy link

codecov bot commented May 31, 2022

Codecov Report

Base: 83.82% // Head: 85.99% // Increases project coverage by +2.16% 🎉

Coverage data is based on head (94da186) compared to base (beecb91).
Patch coverage: 98.64% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #58      +/-   ##
==========================================
+ Coverage   83.82%   85.99%   +2.16%     
==========================================
  Files           1        1              
  Lines         303      357      +54     
==========================================
+ Hits          254      307      +53     
- Misses         49       50       +1     
Impacted Files Coverage Δ
src/LimitedLDLFactorizations.jl 85.99% <98.64%> (+2.16%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@geoffroyleconte geoffroyleconte requested a review from dpo May 31, 2022 18:53
src/LimitedLDLFactorizations.jl Outdated Show resolved Hide resolved
src/LimitedLDLFactorizations.jl Outdated Show resolved Hide resolved
@dpo dpo merged commit 2b38c8b into JuliaSmoothOptimizers:main Aug 25, 2022
@geoffroyleconte geoffroyleconte deleted the in-place branch August 25, 2022 19:15
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants