Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Free mps #21

Merged
merged 3 commits into from
Apr 2, 2020
Merged

Free mps #21

merged 3 commits into from
Apr 2, 2020

Conversation

mtanneau
Copy link
Collaborator

Adds support for parsing Free MPS format. Free MPS should cover almost all cases; the only limitation is that names should not contain any spaces.

A few points and questions:

  • I expanded existing tests to run with both free and fixed format. Should we have more?
  • Markers in the COLUMNS section (e.g., integrality markers) are ignored. An @error message is displayed though
  • Currently, there is no automatic detection of whether the file is in fixed or free format. The format must be specified as a keyword argument to readqps (default value is :fixed).

@codecov
Copy link

codecov bot commented Mar 31, 2020

Codecov Report

Merging #21 into master will decrease coverage by 0.01%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #21      +/-   ##
==========================================
- Coverage    77.5%   77.48%   -0.02%     
==========================================
  Files           2        2              
  Lines         369      422      +53     
==========================================
+ Hits          286      327      +41     
- Misses         83       95      +12
Impacted Files Coverage Δ
src/readqps.jl 77.43% <75%> (-0.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ec0029...96a020f. Read the comment docs.

@dpo
Copy link
Member

dpo commented Apr 2, 2020

I'm having trouble finding the time to review this in detail because the code doesn't look like my original code anymore... I'm trusting you. Many thanks for all those improvements!

@dpo dpo merged commit 0bd8eac into JuliaSmoothOptimizers:master Apr 2, 2020
@mtanneau mtanneau deleted the FreeMPS branch April 2, 2020 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants