Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rank and shifted rank #79

Merged
merged 3 commits into from
Aug 27, 2022
Merged

Rank and shifted rank #79

merged 3 commits into from
Aug 27, 2022

Conversation

dpo
Copy link
Member

@dpo dpo commented Aug 25, 2022

#59 rebased

@dpo dpo mentioned this pull request Aug 25, 2022
@codecov
Copy link

codecov bot commented Aug 25, 2022

Codecov Report

Base: 65.35% // Head: 59.80% // Decreases project coverage by -5.55% ⚠️

Coverage data is based on head (5325ce2) compared to base (7534fcf).
Patch coverage: 58.18% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #79      +/-   ##
==========================================
- Coverage   65.35%   59.80%   -5.56%     
==========================================
  Files          16       18       +2     
  Lines         459      510      +51     
==========================================
+ Hits          300      305       +5     
- Misses        159      205      +46     
Impacted Files Coverage Δ
src/psvd.jl 47.97% <ø> (+1.26%) ⬆️
src/Rank.jl 28.57% <28.57%> (ø)
src/ShiftedProximalOperators.jl 63.33% <80.00%> (+3.33%) ⬆️
src/shiftedRank.jl 90.90% <90.90%> (ø)
src/shiftedRootNormLhalf.jl 23.80% <0.00%> (-61.91%) ⬇️
src/shiftedNormL0.jl 31.25% <0.00%> (-56.25%) ⬇️
src/shiftedNormL1.jl 35.71% <0.00%> (-42.86%) ⬇️
src/utils.jl 100.00% <0.00%> (+100.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dpo dpo force-pushed the MohamedLaghdafHABIBOULLAH-Rank branch 8 times, most recently from cc9f630 to 6a6882d Compare August 27, 2022 04:20
@dpo dpo force-pushed the MohamedLaghdafHABIBOULLAH-Rank branch from 6a6882d to 5325ce2 Compare August 27, 2022 04:35
@dpo dpo changed the title Mohamed laghdaf habiboullah rank Rank and shifted rank Aug 27, 2022
@dpo dpo merged commit f565f2f into master Aug 27, 2022
@dpo dpo deleted the MohamedLaghdafHABIBOULLAH-Rank branch August 27, 2022 05:07
@dpo
Copy link
Member Author

dpo commented Aug 27, 2022

Thank you @MohamedLaghdafHABIBOULLAH !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants