Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use SolverCore in tests #207

Merged
merged 3 commits into from
Dec 26, 2023
Merged

Conversation

Jay-sanjay
Copy link
Contributor

@Jay-sanjay Jay-sanjay commented Nov 20, 2023

This PR is related to #197

PR CheckList

  • Add SolverCore
  • Add tests

@Jay-sanjay
Copy link
Contributor Author

@tmigot Sir would you please provide workflows approval to this PR.

Copy link
Contributor

Package name latest stable
DCISolver.jl
JSOSolvers.jl
Percival.jl

@Jay-sanjay
Copy link
Contributor Author

@tmigot Sir would you please provide workflows approval to this PR.

Copy link

codecov bot commented Dec 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ebf23c3) 97.32% compared to head (666790a) 97.32%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #207   +/-   ##
=======================================
  Coverage   97.32%   97.32%           
=======================================
  Files           8        8           
  Lines         224      224           
=======================================
  Hits          218      218           
  Misses          6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Package name latest stable
DCISolver.jl
JSOSolvers.jl
Percival.jl

Copy link
Member

@tmigot tmigot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@tmigot tmigot merged commit c1f7fbb into JuliaSmoothOptimizers:main Dec 26, 2023
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants