Skip to content
This repository has been archived by the owner on May 4, 2019. It is now read-only.

Clash with BinDeps in definition of | #17

Closed
kmsquire opened this issue Nov 18, 2013 · 5 comments
Closed

Clash with BinDeps in definition of | #17

kmsquire opened this issue Nov 18, 2013 · 5 comments

Comments

@kmsquire
Copy link
Contributor

I haven't looked closely, but this might just need to be changed to |>.
(Of course, the same change might be needed in BinDeps...)

julia> using Winston
Warning: New definition 
    |(SynchronousStepCollection,Any) at /home/kmsquire/.julia/v0.2/BinDeps/src/BinDeps.jl:283
is ambiguous with: 
    |(Any,NAtype) at /home/kmsquire/.julia/v0.2/DataArrays/src/operators.jl:502.
To fix, define 
    |(SynchronousStepCollection,NAtype)
before the new definition.
Warning: New definition 
    |(Any,SynchronousStepCollection) at /home/kmsquire/.julia/v0.2/BinDeps/src/BinDeps.jl:286
is ambiguous with: 
    |(NAtype,Any) at /home/kmsquire/.julia/v0.2/DataArrays/src/operators.jl:502.
To fix, define 
    |(NAtype,SynchronousStepCollection)
before the new definition.
@kmsquire
Copy link
Contributor Author

Sorry, wrong package!

@kmsquire kmsquire reopened this Nov 18, 2013
@kmsquire
Copy link
Contributor Author

(It's BinDeps, not Winston)

@johnmyleswhite
Copy link
Member

This sort of thing is going to be a recurring problem for us. Is there any solution we can use other than adding the automatically proposed method? I really don't want to get involved in an "ambiguity-warning prevention" arms race.

Just to be sure, the version of | we're working with really is our OR operator, right?

@simonster
Copy link
Member

I don't think we can actually add the proposed definition since we'd need to pull in BinDeps to do it, but since | and other bitwise operators are only really meaningful for integers and arrays of integers, we could make these definitions apply to Integer instead of Any, which would avoid the ambiguity.

@johnmyleswhite
Copy link
Member

Totally right. Let's do that.

kmsquire added a commit that referenced this issue Dec 6, 2013
kmsquire added a commit that referenced this issue Dec 6, 2013
johansigfrids pushed a commit to johansigfrids/DataArrays.jl that referenced this issue Aug 19, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants