Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add convolve for DiscreteNonParametric #1523

Closed
wants to merge 7 commits into from
Closed

Add convolve for DiscreteNonParametric #1523

wants to merge 7 commits into from

Commits on Mar 22, 2022

  1. Add convolve for DiscreteNonParametric 

    DiscreteNonParametric convolution has a very nice trivial closed form. It was not implemented.

This pull request implements it.
    @iampritishpatil
    iampritishpatil committed Mar 22, 2022
    Configuration menu
    Copy the full SHA
    15ec552 View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2022

  1. Update src/convolution.jl 

    Co-authored-by: David Widmann <devmotion@users.noreply.github.com>
    @iampritishpatil @devmotion
    iampritishpatil and devmotion committed Mar 23, 2022
    Configuration menu
    Copy the full SHA
    62331ac View commit details
    Browse the repository at this point in the history

  2. Use Set, instead of splatting. 

    Co-authored-by: David Widmann <devmotion@users.noreply.github.com>
    @iampritishpatil @devmotion
    iampritishpatil and devmotion committed Mar 23, 2022
    Configuration menu
    Copy the full SHA
    735a33f View commit details
    Browse the repository at this point in the history

  3. Fix type stability of elements. 

    Doesn't preserve the type of the Vector, but perhaps this is better ....

Co-authored-by: David Widmann <devmotion@users.noreply.github.com>
    @iampritishpatil @devmotion
    iampritishpatil and devmotion committed Mar 23, 2022
    Configuration menu
    Copy the full SHA
    1c05992 View commit details
    Browse the repository at this point in the history

  4. Apply suggestions from code review 

    use functions to access the support and probabilities, and write as one loop.

Co-authored-by: David Widmann <devmotion@users.noreply.github.com>
    @iampritishpatil @devmotion
    iampritishpatil and devmotion committed Mar 23, 2022
    Configuration menu
    Copy the full SHA
    af9bc65 View commit details
    Browse the repository at this point in the history

  5. Added a test set. 

    Removed check args:
We know the convovultion is a proper distribution.
    @iampritishpatil
    iampritishpatil committed Mar 23, 2022
    Configuration menu
    Copy the full SHA
    4b27856 View commit details
    Browse the repository at this point in the history

  6. minor rename for consistency

    @iampritishpatil
    iampritishpatil committed Mar 23, 2022
    Configuration menu
    Copy the full SHA
    f85407a View commit details
    Browse the repository at this point in the history