Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document parameters for noncentral distributions #1632

Merged
merged 2 commits into from Oct 27, 2022
Merged

Document parameters for noncentral distributions #1632

merged 2 commits into from Oct 27, 2022

Conversation

rikhuijzer
Copy link
Contributor

This makes it easier to people to figure out which parameter of the NoncentralT(ν, λ) means what, and adds a basic description for the noncentral distributions too.

Copy link
Member

@devmotion devmotion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only some minor suggestions.

src/univariate/continuous/noncentralt.jl Outdated Show resolved Hide resolved
src/univariate/continuous/noncentralbeta.jl Outdated Show resolved Hide resolved
src/univariate/continuous/noncentralf.jl Outdated Show resolved Hide resolved
Co-authored-by: David Widmann <devmotion@users.noreply.github.com>
@codecov-commenter
Copy link

codecov-commenter commented Oct 27, 2022

Codecov Report

Base: 85.95% // Head: 85.95% // No change to project coverage 👍

Coverage data is based on head (6b8db47) compared to base (a31ebc4).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1632   +/-   ##
=======================================
  Coverage   85.95%   85.95%           
=======================================
  Files         129      129           
  Lines        8105     8105           
=======================================
  Hits         6967     6967           
  Misses       1138     1138           
Impacted Files Coverage Δ
src/univariate/continuous/noncentralbeta.jl 100.00% <ø> (ø)
src/univariate/continuous/noncentralf.jl 91.66% <ø> (ø)
src/univariate/continuous/noncentralt.jl 90.90% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@devmotion devmotion merged commit 5290038 into JuliaStats:master Oct 27, 2022
@devmotion
Copy link
Member

Thank you!

@rikhuijzer rikhuijzer deleted the rh/document-noncentral-params branch October 27, 2022 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants