Moments of MixtureModel no longer includes components with 0 probability #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does anyone know why the build is failing? |
|
These look like incidental errors. Do tests pass on your local machine? |
|
Tests appear to pass. |
|
Changes Unknown when pulling bbc9403 on LaurenceA:mixture-moments into * on JuliaStats:master*. |
lindahua
added a commit
that referenced
this pull request
Aug 25, 2014
Moments of MixtureModel no longer includes components with 0 probability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If, some mixture components have 0 probability, but moments that are Inf or NaN, e.g.
then this can cause the mixture moments to be Inf or NaN, even when they finite.
Here, we fix this, by not incorporating mixture components with 0 probability in the moment computation.