-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add compat for statsmodels 0.7 #512
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## v1 #512 +/- ##
==========================================
+ Coverage 87.39% 88.75% +1.35%
==========================================
Files 7 8 +1
Lines 952 1040 +88
==========================================
+ Hits 832 923 +91
+ Misses 120 117 -3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Okay, I've double checked at least the ubuntu runs to make sure that statsmodels 0.7 was used and all tests are passing so I think this is good to go! |
3494ea9
to
4dbbf59
Compare
4dbbf59
to
172152a
Compare
nightly failures are due to the "evaluated to nonboolean" change for |
We will tag 0.7 very soon (
probably todayahahaha good one...) with changes toFunctionTerm
that are breaking but do not directly affect anything that GLM itself uses. This PR should not be merged until 0.7 is tagged and CI can be run to ensure that nothing breaks in GLM, so I'll start this in draft mode and flip it out when it's time to check CI.Update: 0.7 is now released. I've added bumped the patch version here and also fixed a bug where we were defining our own
formula
function instead of creating a method forStatsModels.formula
.Update to teh update: based on #500, I re-based this on a commit before #339 was merged, targeting a "backport" branch called
v1
.