add compat for statsmodels 0.7 #512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## v1 #512 +/- ##
==========================================
+ Coverage 87.39% 88.75% +1.35%
==========================================
Files 7 8 +1
Lines 952 1040 +88
==========================================
+ Hits 832 923 +91
+ Misses 120 117 -3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
kleinschmidt
requested review from
palday and
nalimilan
and removed request for
palday
|
Okay, I've double checked at least the ubuntu runs to make sure that statsmodels 0.7 was used and all tests are passing so I think this is good to go! |
palday
approved these changes
Mar 14, 2023
kleinschmidt
force-pushed
the
dfk/statsmodels-7
branch
from
3494ea9
to
4dbbf59
Compare
kleinschmidt
force-pushed
the
dfk/statsmodels-7
branch
from
4dbbf59
to
172152a
Compare
|
nightly failures are due to the "evaluated to nonboolean" change for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We will tag 0.7 very soon (
probably todayahahaha good one...) with changes toFunctionTermthat are breaking but do not directly affect anything that GLM itself uses. This PR should not be merged until 0.7 is tagged and CI can be run to ensure that nothing breaks in GLM, so I'll start this in draft mode and flip it out when it's time to check CI.Update: 0.7 is now released. I've added bumped the patch version here and also fixed a bug where we were defining our own
formulafunction instead of creating a method forStatsModels.formula.Update to teh update: based on #500, I re-based this on a commit before #339 was merged, targeting a "backport" branch called
v1.