Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only define methods for sparse matrices when CHOLMOD is available. #61

Merged
merged 3 commits into from
Jun 9, 2017

Conversation

andreasnoack
Copy link
Member

Fixes #43. This will most likely also drop support for 0.4.

@ararslan
Copy link
Member

ararslan commented Apr 11, 2017

The @statics shouldn't be necessary at the top level, otherwise LGTM

@ararslan
Copy link
Member

Looks like this is failing on Julia 0.4 since there's no SparseArrays submodule of Base. While I don't mind dropping support for 0.4 at this point, I wonder if this could be handled more effectively by putting all of the sparse stuff in its own file, then doing

if isdefined(Base, :SparseArrays) && isdefined(Base.SparseArrays, :CHOLMOD)
    include("sparse.jl")
end

in src/PDMats.jl.

@aviks
Copy link

aviks commented Jun 9, 2017

Bump. Could we get this in please? This breaks about a dozen other packages (via Distributions) when run with a non-GPL julia build.

@andreasnoack andreasnoack changed the title WIP: Only define methods for sparse matrices when CHOLMOD is available. Only define methods for sparse matrices when CHOLMOD is available. Jun 9, 2017
@andreasnoack andreasnoack merged commit 3817866 into master Jun 9, 2017
@andreasnoack andreasnoack deleted the anj/cholmod branch June 9, 2017 13:29
@aviks
Copy link

aviks commented Jun 9, 2017

Thanks! @andreasnoack . Appreciate it. Is this ready for a new tag?

@andreasnoack
Copy link
Member Author

Yes, I think so. I'll do it as soon as all tests have passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants