Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix depwarn on 0.6 due to vectorized functions #20

Merged
merged 1 commit into from
Sep 11, 2016

Conversation

yuyichao
Copy link
Contributor

@yuyichao yuyichao commented Sep 5, 2016

Requires JuliaLang/Compat.jl#280 and a new Compat tag.

@yuyichao
Copy link
Contributor Author

yuyichao commented Sep 9, 2016

Looks like this needs the promote op fix to be backported to 0.5.

@yuyichao
Copy link
Contributor Author

yuyichao commented Sep 9, 2016

I believe this is fixed on 0.5.0-rc4 by JuliaLang/julia@53c7720 Windows nightly haven't caught up yet (it's on 0.6.0-dev.333) so I guess I'll try again when a new windows nightly is available. Should be good to go other than that....

@yuyichao
Copy link
Contributor Author

Nightly are updated and all CI passed. This is ready now.

@ararslan ararslan merged commit d43c100 into JuliaStats:master Sep 11, 2016
@ararslan
Copy link
Member

Great, thanks!

@yuyichao yuyichao deleted the 0.6-dep branch September 11, 2016 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants