Drop Missings and use Base.nonmissingtype (#151)

* travis: test on 1.2 and 1.3, not 1.1. docs on 1.2. drop osx. * drop Missings and use Base.nonmissingtype instead of Missings.T
JuliaStats · Sep 16, 2019 · d03b5c2 · d03b5c2
1 parent 91efc7a
commit d03b5c2
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 6 deletions.
diff --git a/.travis.yml b/.travis.yml
@@ -2,10 +2,10 @@
 language: julia
 os:
   - linux
-  - osx
 julia:
   - 1.0
-  - 1.1
+  - 1.2
+  - 1.3
   - nightly
 matrix:
   allow_failures:
@@ -17,7 +17,7 @@ after_success:
 jobs:
   include:
     - stage: "Documentation"
-      julia: 1.1
+      julia: 1.2
       os: linux
       script:
         - julia --project=docs/ -e 'using Pkg; Pkg.develop(PackageSpec(path=pwd()));

diff --git a/Project.toml b/Project.toml
@@ -6,7 +6,6 @@ version = "0.6.3"
 CategoricalArrays = "324d7699-5711-5eae-9e2f-1d82baa6b597"
 DataStructures = "864edb3b-99cc-5e75-8d2d-829cb0a9cfe8"
 LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e"
-Missings = "e1d29d7a-bbdc-5cf2-9ac0-f12de2c33e28"
 ShiftedArrays = "1277b4bf-5013-50f5-be3d-901d8477a67a"
 SparseArrays = "2f01184e-e22b-5df5-ae63-d93ebab69eaf"
 StatsBase = "2913bbd2-ae8a-5f71-8c99-4fb6c76f3a91"

diff --git a/src/StatsModels.jl b/src/StatsModels.jl
@@ -8,7 +8,6 @@ using DataStructures
 
 using SparseArrays
 using LinearAlgebra
-using Missings
 
 using Tables: ColumnTable
 

diff --git a/src/modelframe.jl b/src/modelframe.jl
@@ -68,7 +68,7 @@ function missing_omit(d::T) where T<:ColumnTable
     rows = findall(nonmissings)
     d_nonmissing =
         NamedTuple{Tables.names(T)}(tuple((copyto!(similar(col,
-                                                           Missings.T(eltype(col)),
+                                                           Base.nonmissingtype(eltype(col)),
                                                            length(rows)),
                                                    view(col, rows)) for col in d)...))
     d_nonmissing, nonmissings