Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delegate coefnames for wrapped models to model frame #60

Merged
merged 1 commit into from
May 21, 2018

Conversation

kleinschmidt
Copy link
Member

This is a StatsBase API method that was missing.

fixes JuliaStats/GLM.jl#235

@codecov-io
Copy link

codecov-io commented May 18, 2018

Codecov Report

Merging #60 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #60      +/-   ##
==========================================
+ Coverage   93.85%   93.87%   +0.01%     
==========================================
  Files           6        6              
  Lines         358      359       +1     
==========================================
+ Hits          336      337       +1     
  Misses         22       22
Impacted Files Coverage Δ
src/statsmodel.jl 86.84% <100%> (+0.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdeb053...38c33ee. Read the comment docs.

@kleinschmidt
Copy link
Member Author

The alternative way to implement this is to delegate it to the wrapped model itself, and leave it up to the model packages to do something sensible (like use the rownames of the coeftable). That might be slightly safer in cases where the model frame coefnames are not identical to the coeftable rownames, but I can't think of such a case off the top of my head...

Copy link
Member

@nalimilan nalimilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I agree that's the best approach, as the model does not currently have any notion of coefficient names anyway.

@kleinschmidt kleinschmidt merged commit d4ae815 into master May 21, 2018
@kleinschmidt kleinschmidt deleted the dfk/coefnames branch May 21, 2018 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants