Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to PrettyTables printing #520

Merged
merged 8 commits into from
Nov 21, 2023

Conversation

ValentinKaisermayer
Copy link
Contributor

@ValentinKaisermayer ValentinKaisermayer commented Nov 15, 2023

Gets rid of a lot of code so that we do not have to reinvent the wheel. Printing is a little different (tail is omitted, top and bottom hline).

closes #514
closes #428

@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (6db8220) 88.29% compared to head (fea5ff4) 86.30%.

❗ Current head fea5ff4 differs from pull request most recent head 76da9a2. Consider uploading reports for the commit 76da9a2 to get more accurate results

Files Patch % Lines
src/timearray.jl 94.44% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #520      +/-   ##
==========================================
- Coverage   88.29%   86.30%   -1.99%     
==========================================
  Files          12       12              
  Lines         752      672      -80     
==========================================
- Hits          664      580      -84     
- Misses         88       92       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ValentinKaisermayer
Copy link
Contributor Author

@iblislin Can you review this?

src/TimeSeries.jl Outdated Show resolved Hide resolved
@iblislin iblislin merged commit c286db1 into JuliaStats:master Nov 21, 2023
4 checks passed
@iblislin
Copy link
Collaborator

Thanks for your contributions!

iblislin added a commit to JuliaQuant/MarketData.jl that referenced this pull request Nov 21, 2023
iblislin added a commit to JuliaQuant/MarketData.jl that referenced this pull request Nov 21, 2023
@ValentinKaisermayer ValentinKaisermayer deleted the pretty-tables branch November 21, 2023 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Really inefficient printing for large TimeArrays TimeArray printing return error in too small terminal
3 participants