Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Really inefficient printing for large TimeArrays #514

Closed
ValentinKaisermayer opened this issue Jun 28, 2022 · 3 comments · Fixed by #520
Closed

Really inefficient printing for large TimeArrays #514

ValentinKaisermayer opened this issue Jun 28, 2022 · 3 comments · Fixed by #520

Comments

@ValentinKaisermayer
Copy link
Contributor

The main source seems to be this line:

strs = _showval.(values(ta))

only a very small subset of strs is used later.

@ValentinKaisermayer
Copy link
Contributor Author

related #428

@ValentinKaisermayer
Copy link
Contributor Author

Also if a TimeArray is a field of a struct the whole TimeArray is printed. Is there no summary view?

@piechologist
Copy link

piechologist commented Sep 30, 2023

Regarding large TimeArrays, I put the following code in my startup.jl:

using TimeSeries
Base.show(io::IO, ::MIME"text/plain", ta::TimeArray) = if length(ta) > 6
    println("Showing only the head of ", length(ta), " rows…")
    show(io, head(ta))
else
    show(io, ta)
end

It's just my personal preference as I usually have many rows but relatively few columns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants