Add chopprefix/chopsuffix methods returning InlineString
#41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickrobinson251
force-pushed
the
npr/40-chop-prefix-suffix
branch
2 times, most recently
from
a9dff86
to
27be376
Compare
- These methods, with `AbstractString` prefix/suffix, now return an `InlineString` of the same type as the input (except `String1` which always returns `String3`) instead of returning a `SubString`.
nickrobinson251
force-pushed
the
npr/40-chop-prefix-suffix
branch
from
27be376
to
0687a71
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chopprefix/chopsuffixreturning InlineString #40based on top of Fixchopon strings with multi-byte graphemes #39 (i.e. includes those commits) so PR#39 should go in first and i'll mark this as draft for now, although it's ready for review