Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve printing for homogenous arrays #63

Merged

Conversation

simeonschaub
Copy link
Contributor

This came up on Slack. Makes arrays of InlineStrings a bit easier to
read.

This came up on Slack. Makes arrays of `InlineString`s a bit easier to
read.
Copy link
Collaborator

@nickrobinson251 nickrobinson251 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! thanks, @simeonschaub

@codecov-commenter
Copy link

codecov-commenter commented Jan 26, 2023

Codecov Report

Merging #63 (d7105ec) into main (9b4ff8f) will increase coverage by 0.02%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main      #63      +/-   ##
==========================================
+ Coverage   93.02%   93.04%   +0.02%     
==========================================
  Files           1        1              
  Lines         674      676       +2     
==========================================
+ Hits          627      629       +2     
  Misses         47       47              
Impacted Files Coverage Δ
src/InlineStrings.jl 93.04% <100.00%> (+0.02%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@nickrobinson251
Copy link
Collaborator

Before we had

julia> x = String31["foo", "bar"];

julia> println(x)
String31[String31("foo"), String31("bar")]

Now we have:

julia> println(x)
String31["foo", "bar"]

@nickrobinson251 nickrobinson251 merged commit cc186c6 into JuliaStrings:main Jan 26, 2023
@simeonschaub simeonschaub deleted the sds/homogenous_array_show branch January 26, 2023 22:39
Copy link
Member

@quinnj quinnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @simeonschaub!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants