Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rebased cmake updates #147

Merged
merged 4 commits into from
Mar 30, 2019
Merged

rebased cmake updates #147

merged 4 commits into from
Mar 30, 2019

Commits on Mar 30, 2019

  1. Use a target property instead of CMAKE_C_FLAGS 

    It is a global property, which is not great when importing utf8proc in other CMake projects.
    @per-gron @stevengj
    per-gron authored and stevengj committed Mar 30, 2019
    Configuration menu
    Copy the full SHA
    4534ad4 View commit details
    Browse the repository at this point in the history

  2. Use target properties instead of add_definitions 

    It modifies builds settings globally, which is not great when using
the library as part of a bigger CMake build
    @stevengj
    Per Eckerdal authored and stevengj committed Mar 30, 2019
    Configuration menu
    Copy the full SHA
    a541a25 View commit details
    Browse the repository at this point in the history

  3. Expose header search path with target_include_directories 

    This makes it possible to use utf8proc in a larger CMake based project
with

add_subdirectory(utf8proc)
target_link_libraries(my_app utf8proc)
    @stevengj
    Per Eckerdal authored and stevengj committed Mar 30, 2019
    Configuration menu
    Copy the full SHA
    938aba3 View commit details
    Browse the repository at this point in the history

  4. more rebase fixes

    @stevengj
    stevengj committed Mar 30, 2019
    Configuration menu
    Copy the full SHA
    71bbec9 View commit details
    Browse the repository at this point in the history