New data file generator with support for UCD 13 & 14 #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(UNICODE_VERSION): Added `14.0.0` default. [Note: It may be possible to remove the similar statement in data/Makefile but it may require updating all the calls to `$(MAKE) -C data …` in this file.] (test/misc): Use above UNICODE_VERSION var so that this target also builds with original utf8proc_data.c file. [Note: This test in test/misc is now redundant when using the new utf8proc_data.c files.] utf8proc.c - Restored changes from 610730f. (utf8proc_category): Fixed new warning.
stevengj
reviewed
Sep 17, 2021
| @@ -26,6 +26,8 @@ MAJOR=2 | |||
| MINOR=4 | |||
| PATCH=1 | |||
|
|
|||
| UNICODE_VERSION ?= 14.0.0 | |||
There was a problem hiding this comment.
Upgrading to Unicode 14 should happen in a separate PR.
stevengj
reviewed
Sep 17, 2021
|
|
||
|
|
||
| def Print (s): | ||
| print(s, file=sys.stderr) |
There was a problem hiding this comment.
Please use PEP-8 style (https://www.python.org/dev/peps/pep-0008/), e.g. 4 space indenting … see e.g. https://github.com/hhatto/autopep8
usually python functions are not capitalized…
You mentioned that you didn't know Python before, and unfortunately this code is rather non-idiomatic.
stevengj
reviewed
Sep 17, 2021
| return DDir+ "/" +name+ ".txt" | ||
|
|
||
| def Sed (expr, file): | ||
| return os.popen("/usr/bin/sed -En '" +expr+ "' '" +TextFile(file)+ "'", 'r', 1) |
There was a problem hiding this comment.
Python has its own regex support; it's a little odd to call out to sed etcetera
|
Is there any update on this? |
|
Closed in favor of #258. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #227.