Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify_rules.jl: Add rules for sinh, cosh #534

Merged
merged 5 commits into from
Aug 2, 2023

Conversation

eschnett
Copy link
Contributor

Add rules for sinh, cosh, similar to those for sin and cos.

Add rules for sinh, cosh, similar to those for sin and cos.
@github-actions
Copy link
Contributor

github-actions bot commented Jul 10, 2023

Benchmark Results

master 04ef715... t[master]/t[04ef715...]
overhead/acrule/a+2 1.09 ± 0.24 μs 1.05 ± 0.26 μs 1.04
overhead/acrule/a+2+b 1.08 ± 0.25 μs 1.03 ± 0.2 μs 1.05
overhead/acrule/a+b 0.349 ± 0.0061 μs 0.354 ± 0.014 μs 0.985
overhead/acrule/noop:Int 26.5 ± 0.6 ns 26.8 ± 1.2 ns 0.989
overhead/acrule/noop:Sym 0.0453 ± 0.0074 μs 0.0482 ± 0.0077 μs 0.94
overhead/rule/noop:Int 0.0444 ± 0.0013 μs 0.0446 ± 0.0011 μs 0.995
overhead/rule/noop:Sym 0.0582 ± 0.0024 μs 0.0682 ± 0.0023 μs 0.853
overhead/rule/noop:Term 0.0593 ± 0.0022 μs 0.0682 ± 0.0022 μs 0.869
overhead/ruleset/noop:Int 0.165 ± 0.0022 μs 0.162 ± 0.002 μs 1.02
overhead/ruleset/noop:Sym 0.191 ± 0.0051 μs 0.18 ± 0.0051 μs 1.06
overhead/ruleset/noop:Term 4.26 ± 0.26 μs 4.31 ± 0.26 μs 0.987
overhead/simplify/noop:Int 0.224 ± 0.005 μs 0.234 ± 0.0082 μs 0.956
overhead/simplify/noop:Sym 0.235 ± 0.0036 μs 0.25 ± 0.0038 μs 0.941
overhead/simplify/noop:Term 0.0443 ± 0.0035 ms 0.0444 ± 0.0039 ms 0.998
overhead/simplify/randterm (+, *):serial 0.123 ± 0.0018 s 0.121 ± 0.0025 s 1.02
overhead/simplify/randterm (+, *):thread 0.0777 ± 0.017 s 0.0755 ± 0.018 s 1.03
overhead/simplify/randterm (/, *):serial 0.274 ± 0.0079 ms 0.273 ± 0.0082 ms 1
overhead/simplify/randterm (/, *):thread 0.317 ± 0.01 ms 0.309 ± 0.0095 ms 1.03
overhead/substitute/a 0.0723 ± 0.0014 ms 0.0718 ± 0.0014 ms 1.01
overhead/substitute/a,b 0.0631 ± 0.0015 ms 0.0636 ± 0.0016 ms 0.992
overhead/substitute/a,b,c 22.6 ± 0.4 μs 23.5 ± 0.5 μs 0.962
polyform/easy_iszero 0.0379 ± 0.0031 ms 0.0379 ± 0.0023 ms 1
polyform/isone 3.4 ± 0 ns 3 ± 0.1 ns 1.13
polyform/iszero 1.57 ± 0.03 ms 1.54 ± 0.031 ms 1.02
polyform/simplify_fractions 2.22 ± 0.038 ms 2.18 ± 0.042 ms 1.02
time_to_load 5.28 ± 0.028 s 5.25 ± 0.0072 s 1.01

Benchmark Plots

A plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR.
Go to "Actions"->"Benchmark a pull request"->[the most recent run]->"Artifacts" (at the bottom).

@shashi
Copy link
Member

shashi commented Jul 17, 2023

could you add a few tests?

@shashi
Copy link
Member

shashi commented Jul 17, 2023

You also want to edit https://github.com/JuliaSymbolics/SymbolicUtils.jl/blob/master/src/utils.jl#L37

otherwise this ruleset will not be applied.

@eschnett eschnett marked this pull request as draft July 27, 2023 20:33
@eschnett eschnett marked this pull request as ready for review July 27, 2023 20:44
@eschnett
Copy link
Contributor Author

@shashi Did that – could you let the CI workflows run again?

@eschnett
Copy link
Contributor Author

The test failure seems unreladed.

@shashi
Copy link
Member

shashi commented Jul 31, 2023

@YingboMa failure related to #535

@shashi shashi merged commit be2ee4a into JuliaSymbolics:master Aug 2, 2023
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants