Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix div with rational numbers to fix simplify_fractions #550

Merged
merged 2 commits into from
Sep 8, 2023

Conversation

shashi
Copy link
Member

@shashi shashi commented Sep 8, 2023

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

Benchmark Results

master 7737865... t[master]/t[7737865...]
overhead/acrule/a+2 1.09 ± 0.26 μs 1.1 ± 0.24 μs 0.991
overhead/acrule/a+2+b 1.09 ± 0.26 μs 1.08 ± 0.25 μs 1.01
overhead/acrule/a+b 0.351 ± 0.009 μs 0.35 ± 0.0097 μs 1
overhead/acrule/noop:Int 26.7 ± 0.4 ns 26.1 ± 0.5 ns 1.02
overhead/acrule/noop:Sym 0.0476 ± 0.0079 μs 0.0466 ± 0.0075 μs 1.02
overhead/rule/noop:Int 0.0446 ± 0.0019 μs 0.0451 ± 0.0016 μs 0.99
overhead/rule/noop:Sym 0.0594 ± 0.0032 μs 0.0586 ± 0.0029 μs 1.01
overhead/rule/noop:Term 0.0592 ± 0.0034 μs 0.0588 ± 0.003 μs 1.01
overhead/ruleset/noop:Int 0.168 ± 0.0022 μs 0.164 ± 0.0037 μs 1.02
overhead/ruleset/noop:Sym 0.202 ± 0.006 μs 0.192 ± 0.0081 μs 1.05
overhead/ruleset/noop:Term 4.44 ± 0.36 μs 4.29 ± 0.3 μs 1.04
overhead/simplify/noop:Int 0.223 ± 0.0098 μs 0.228 ± 0.0086 μs 0.98
overhead/simplify/noop:Sym 0.242 ± 0.0058 μs 0.25 ± 0.0057 μs 0.967
overhead/simplify/noop:Term 0.0438 ± 0.0036 ms 0.0457 ± 0.0037 ms 0.958
overhead/simplify/randterm (+, *):serial 0.164 ± 0.0014 s 0.166 ± 0.001 s 0.989
overhead/simplify/randterm (+, *):thread 0.114 ± 0.017 s 0.115 ± 0.017 s 0.997
overhead/simplify/randterm (/, *):serial 0.273 ± 0.0096 ms 0.283 ± 0.01 ms 0.966
overhead/simplify/randterm (/, *):thread 0.315 ± 0.01 ms 0.328 ± 0.011 ms 0.962
overhead/substitute/a 0.074 ± 0.0021 ms 0.0713 ± 0.0018 ms 1.04
overhead/substitute/a,b 0.0649 ± 0.0021 ms 0.0629 ± 0.0018 ms 1.03
overhead/substitute/a,b,c 23.6 ± 0.8 μs 21.9 ± 0.7 μs 1.08
polyform/easy_iszero 0.0387 ± 0.0038 ms 0.0385 ± 0.0036 ms 1.01
polyform/isone 3.1 ± 0.1 ns 3.4 ± 0 ns 0.912
polyform/iszero 2.44 ± 0.034 ms 2.39 ± 0.043 ms 1.02
polyform/simplify_fractions 3.28 ± 0.043 ms 3.22 ± 0.042 ms 1.02
time_to_load 5.51 ± 0.015 s 5.49 ± 0.05 s 1

Benchmark Plots

A plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR.
Go to "Actions"->"Benchmark a pull request"->[the most recent run]->"Artifacts" (at the bottom).

@shashi shashi merged commit 6505233 into master Sep 8, 2023
7 of 11 checks passed
@shashi shashi deleted the s/fix-Rational-div branch September 8, 2023 16:23
@ranocha ranocha mentioned this pull request Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant