Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Legend entries now use \legend{} #153

Merged
merged 3 commits into from
Aug 16, 2020
Merged

Legend entries now use \legend{} #153

merged 3 commits into from
Aug 16, 2020

Conversation

mossr
Copy link
Member

@mossr mossr commented Aug 16, 2020

Thanks to the heavy lifting by @mykelk, we now use the \legend{} command for legendentries, which can handle empty entries correctly. This addresses #102

This PR also includes a minor fix to how SmithCircle defined the radius of a TikZ circle, based on this post: https://tex.stackexchange.com/questions/530405/argument-of-pgfmathfloatparse-has-an-extra?noredirect=1&lq=1

@mykelk
Copy link
Member

mykelk commented Aug 16, 2020

Awesome! This looks great. You can go ahead and merge and tag a release when you're ready.

@mossr
Copy link
Member Author

mossr commented Aug 16, 2020

Great! I'm not a JuliaTex member so I can't ;)

@mykelk mykelk merged commit d69d5a4 into JuliaTeX:master Aug 16, 2020
@mykelk mykelk mentioned this pull request Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants