Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workaround over-sensitive ambiguity detection from JuliaLang/julia#36962 #32

Merged
merged 4 commits into from
Sep 6, 2020
Merged

Workaround over-sensitive ambiguity detection from JuliaLang/julia#36962 #32

merged 4 commits into from
Sep 6, 2020

Conversation

tkf
Copy link
Member

@tkf tkf commented Sep 6, 2020 •
edited

This is for avoiding errors like

ERROR: MethodError: no method matching detect_ambiguities(::Module, ::Module; recursive=true, imported=false, ambiguous_bottom=false)
Closest candidates are:
  detect_ambiguities(::Any...; recursive, ambiguous_bottom) at /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.6/Test/src/Test.jl:1423 got unsupported keyword argument "imported"

--- https://travis-ci.com/github/JuliaFolds/BangBang.jl/jobs/381666899#L338

Also:
https://github.com/JuliaFolds/Transducers.jl/runs/1077261987#step:6:37

Commit Message

Workaround over-sensitive ambiguity detection from JuliaLang/julia#36962 (#32)

  • Do not hard-code default options for Test.detect_ambiguities
  • Ignore ambiguities from Base for now

@codecov
Copy link

codecov bot commented Sep 6, 2020 •
edited

Codecov Report

Merging #32 into master will increase coverage by 3.75%.
The diff coverage is 90.90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #32      +/-   ##
==========================================
+ Coverage   85.34%   89.09%   +3.75%     
==========================================
  Files           7        7              
  Lines         191      220      +29     
==========================================
+ Hits          163      196      +33     
+ Misses         28       24       -4
Impacted Files Coverage Δ
src/utils.jl 80.00% <83.33%> (+2.72%) ⬆️
src/Aqua.jl 81.81% <100.00%> (+10.38%) ⬆️
src/ambiguities.jl 81.39% <100.00%> (+8.66%) ⬆️
src/exports.jl 100.00% <0.00%> (ø)
src/stale_deps.jl 100.00% <0.00%> (ø)
src/unbound_args.jl 100.00% <0.00%> (ø)
src/project_extras.jl 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 942561d...4c511ce. Read the comment docs.

@tkf tkf mentioned this pull request Sep 6, 2020
Merged
@tkf tkf changed the title Do not hard-code default options for Test.detect_ambiguities Workaround over-sensitive ambiguity detection from JuliaLang/julia#36962 Sep 6, 2020
@mergify mergify bot merged commit fe03e3f into master Sep 6, 2020
@mergify mergify bot deleted the detect_ambiguities-imported branch September 6, 2020 22:14
mergify bot pushed a commit to JuliaFolds/BangBang.jl that referenced this pull request Sep 6, 2020
@tkf
Update Aqua to workaround ambiguity detection in Julia 1.6.0-DEV.816 (#…
ac5f516 
…197)

See also: JuliaTesting/Aqua.jl#32
@tkf tkf mentioned this pull request Sep 6, 2020
Merged
mergify bot pushed a commit to JuliaFolds/Transducers.jl that referenced this pull request Sep 6, 2020
@tkf
Workaround over-sensitive ambiguity detection from JuliaLang/julia#36962
b1e469e 
 (#419)

* Update to JuliaTesting/Aqua.jl#32
* Don't call test_ambiguities with Base in julia >= 1.6.0-DEV.816
tkf added a commit that referenced this pull request Sep 10, 2020
@tkf
Revert "Workaround over-sensitive ambiguity detection (#32)"
b336f0a 
This reverts commit fe03e3f.
mergify bot pushed a commit that referenced this pull request Sep 11, 2020
@tkf
Revert "Workaround over-sensitive ambiguity detection (#32)" (#41)
4fae552 
This reverts commit fe03e3f.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ready-to-merge:squash
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@tkf