Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it work on Windows #43

Merged
merged 6 commits into from
Sep 14, 2020
Merged

Make it work on Windows #43

merged 6 commits into from
Sep 14, 2020

Conversation

tkf
Copy link
Member

@tkf tkf commented Sep 13, 2020

Commit Message

Make it work on Windows (#43)

  • Run tests on Windows.
  • Ignore carriage returns.

It looks like running tests on Windows didn't catch the carriage
return bug. But it might be worth running tests on Windows anyway to
catch some similar bugs in the future.

@codecov
Copy link

codecov bot commented Sep 13, 2020

Codecov Report

Merging #43 into master will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #43      +/-   ##
==========================================
+ Coverage   89.13%   89.16%   +0.03%     
==========================================
  Files           9        9              
  Lines         322      323       +1     
==========================================
+ Hits          287      288       +1     
  Misses         35       35              
Flag Coverage Δ
#unittests 89.16% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/project_toml_formatting.jl 84.37% <100.00%> (ø)
src/utils.jl 92.98% <100.00%> (+0.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f61fac...3fb957e. Read the comment docs.

@tkf
Copy link
Member Author

tkf commented Sep 13, 2020

D:\a\PyVenvs.jl\PyVenvs.jl\test\Project.toml: Test Failed at C:\Users\runneradmin\.julia\packages\Aqua\PeeP1\src\project_toml_formatting.jl:7
  Expression: result ⊜ true
   Evaluated: ⟪result: 😭 FAILED: D:\a\PyVenvs.jl\PyVenvs.jl\test\Project.toml
    Running `Pkg.resolve` on `D:\a\PyVenvs.jl\PyVenvs.jl\test\Project.toml` will change the content.
    
    --- Original Project.toml
    +++ Pkg's output
    @@ -1,9 +1,9 @@
    -[deps]
    -Aqua = "4c88cf16-eb10-579e-8560-4a9242c79595"
    -Pkg = "44cfe95a-1eb2-52ea-b672-e2afdf69b78f"
    -PyCall = "438e738f-606a-5dbb-bf0a-cddfbfd45ab0"
    -Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
    -
    -[compat]
    -Aqua = "0.4.8"
    -PyCall = "1.90"
    +[deps]
    +Aqua = "4c88cf16-eb10-579e-8560-4a9242c79595"
    +Pkg = "44cfe95a-1eb2-52ea-b672-e2afdf69b78f"
    +PyCall = "438e738f-606a-5dbb-bf0a-cddfbfd45ab0"
    +Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
    +
    +[compat]
    +Aqua = "0.4.8"
    +PyCall = "1.90"
    
⟫ ⊜ true

https://github.com/tkf/PyVenvs.jl/runs/1109571026#step:5:92
tkf/PyVenvs.jl#8

@tkf tkf changed the title windows Make it work on Windows Sep 14, 2020
@tkf tkf merged commit f23d5a2 into master Sep 14, 2020
@tkf tkf deleted the windows branch September 14, 2020 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant