some cleanup, inclusing changing TokenBuffer to use replaces rather than splits #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeInnes
approved these changes
Feb 25, 2019
aquatiko
reviewed
Feb 26, 2019
| For example, `cannot` would be split into `can` and `not`. | ||
| `freeeee` would be replaced with `free` | ||
| """ | ||
| function replaces(ts, ss) |
There was a problem hiding this comment.
@oxinabox if we could give an option to pass boundary here, it will help with some of the rules for TokTok implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change we were talking about in #10
and I think on making it it is cleaner, easier to write.
I also think this kind of rule will be useful for #18
where some of the things you flush are normalized versions of the "raw tokens".
What do you think @MikeInnes ?