Skip to content

Commit

Permalink
connectionlayer: sslupgrade(socket_type_tls) fixup (#941)
Browse files Browse the repository at this point in the history
The sockettype for ConnectionPool.sslupgrade should depend on target_url 
rather than url. These are not necessarily on the same schema. I.e if 
"https_proxy=http://..."
  • Loading branch information
gustafsson committed Oct 18, 2022
1 parent 2377beb commit 868bdfd
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/clientlayers/ConnectionRequest.jl
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ function connectionlayer(handler)
return r
end
if target_url.scheme in ("https", "wss")
io = ConnectionPool.sslupgrade(IOType, io, target_url.host; readtimeout=readtimeout, kw...)
io = ConnectionPool.sslupgrade(socket_type_tls, io, target_url.host; readtimeout=readtimeout, kw...)
end
req.headers = filter(x->x.first != "Proxy-Authorization", req.headers)
end
Expand Down

0 comments on commit 868bdfd

Please sign in to comment.