Fix HTTP.download stack overflow error on "/" paths (#897)

* Fix StackOverflow error as reported in #896

* Fix body summary showing for Dict/NamedTuple bodies

* add test for #896

* Update src/download.jl

Co-authored-by: Frames Catherine White <lyndon.white@invenialabs.co.uk>

* Revert "Update src/download.jl"

This reverts commit 7f82cff.

Co-authored-by: Frames Catherine White <lyndon.white@invenialabs.co.uk>

src/Messages.jl

@@ -570,6 +570,7 @@ function bodysummary(body::Form)
     end
     return "[Message Body was streamed]"
 end
+bodysummary(body::Union{Dict, NamedTuple}) = URIs.escapeuri(body)
 
 function compactstartline(m::Message)
     b = IOBuffer()

src/download.jl

@@ -36,7 +36,7 @@ end
 
 function try_get_filename_from_request(req)
     function file_from_target(t)
-        t == "" && return nothing
+        (t == "" || t == "/") && return nothing
         f = basename(URI(t).path) # URI(...).path to strip out e.g. query parts
         return (f == "" ? file_from_target(dirname(t)) : f)
     end

test/download.jl

@@ -21,6 +21,9 @@ using HTTP
         # HTTP.jl#696
         file = HTTP.download("https://httpbingo.julialang.org/html?a=b")
         @test basename(file) == "html"
+        # HTTP.jl#896
+        file = HTTP.download("https://www.cryst.ehu.es/")
+        @test isfile(file) # just ensure it downloads and doesn't stack overflow
     end
 
     @testset "Content-Disposition" begin