-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix HTTP.download stack overflow error on "/" paths #897
Conversation
cc: @oxinabox. I'm not super familiar with the download code, but this seems to be in the same spirit as what |
Codecov Report
@@ Coverage Diff @@
## master #897 +/- ##
==========================================
+ Coverage 80.12% 80.22% +0.10%
==========================================
Files 36 36
Lines 2878 2903 +25
==========================================
+ Hits 2306 2329 +23
- Misses 572 574 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
We usually write tests using http://test.greenbytes.de/tech/tc2231/ which is like reference API for this particular part of the HTTP spec. I think this one actually corresponds to the absolute path part of spec which is tested at: For which the correct behavour is:
Though all web browsers:
so we might want to match that. |
Co-authored-by: Frames Catherine White <lyndon.white@invenialabs.co.uk>
This reverts commit 7f82cff.
No description provided.