Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for functional parameter (#33) #34

Merged
merged 21 commits into from
May 3, 2020
Merged

Added support for functional parameter (#33) #34

merged 21 commits into from
May 3, 2020

Conversation

pawlizio
Copy link
Collaborator

@pawlizio pawlizio commented Apr 9, 2020

This fixes tilt support for exterior blinds

@coveralls
Copy link

coveralls commented Apr 9, 2020

Coverage Status

Coverage decreased (-0.7%) to 81.631% when pulling 97bb054 on pawlizio:master into b685774 on Julius2342:master.

@Julius2342
Copy link
Owner

Hi @pawlizio !

there is a merge conflict now in your branch. May i kindly ask you to fix this?

I also dont understand your patch, may you write one or two sentences about your change?

Thank you very much!

Best

Julius

@pawlizio
Copy link
Collaborator Author

Dear @Julius2342,

pyvlx has no support to set the functional parameter of a node (see Chapter 10.1.1.4 to 10.1.1.6 and 14 Appendix 2 of Technical Specification for KLF 200 ). On my exterior venetian blinds it is possible to set the tilt of the slats with functional parameter 3.

I moved from tahoma premium box to velux klf in order to be independent from the internet access. With somfy component I was able to set the tilt of my raffstores with home assistant, so I tried to get it also working with velux. Finally it took me some time to understand your code as well as the velux api specification, but luckily I managed to get it working.

I'll try to identify the issue, however I'm not an experienced developer, so it may will take some time to understand where the conflict is.

Best regards,
Paul

@pawlizio
Copy link
Collaborator Author

@Julius2342 I have now resolved the conflict and added more comments to explain my code.

@Julius2342
Copy link
Owner

sigh i broke it again. This time i will fix it ...

@Julius2342
Copy link
Owner

I fixed the conflict in MR #39 May you have a look please?

@pawlizio
Copy link
Collaborator Author

pawlizio commented May 1, 2020

#39 has a problem, as the Blind constructor in node_helper.py get an unexpected keyword argument 'position_parameter'

@Julius2342 Julius2342 merged commit da9c8b5 into Julius2342:master May 3, 2020
@Julius2342
Copy link
Owner

Thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants