Functional parameter #39
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawlizio
reviewed
May 1, 2020
pyvlx/node_helper.py
Outdated
|
|
||
| # Blinds have position and orientation (inherit frame.current_position_fp3) attribute | ||
| if frame.node_type == NodeTypeWithSubtype.EXTERIOR_VENETIAN_BLIND or \ | ||
| frame.node_type == NodeTypeWithSubtype.ADJUSTABLE_SLUTS_ROLLING_SHUTTER or \ | ||
| frame.node_type == NodeTypeWithSubtype.LOUVER_BLIND: | ||
| return Blind(pyvlx=pyvlx, node_id=frame.node_id, name=frame.name, serial_number=frame.serial_number, | ||
| position_parameter=frame.current_position) |
There was a problem hiding this comment.
Blind class has to be modified to have position_parameter in the constructor
Julius2342
commented
May 3, 2020
| @@ -18,6 +18,7 @@ def convert_frame_to_node(pyvlx, frame): | |||
| position_parameter=frame.current_position, rain_sensor=True) | |||
|
|
|||
| if frame.node_type == NodeTypeWithSubtype.ROLLER_SHUTTER or \ | |||
| frame.node_type == NodeTypeWithSubtype.ADJUSTABLE_SLUTS_ROLLING_SHUTTER_WITH_PROJECTION or \ | |||
There was a problem hiding this comment.
Hi @pawlizio ,
in your PR, did you remove ADJUSTABLE_SLUTS_ROLLING_SHUTTER_WITH_PROJECTION by intent?
There was a problem hiding this comment.
Nope, may by a mistake when sorting devices. I tried to group all devices with "orientation of the slats" on functional parameter 3 to Blinds and keep others RollerShutters.
There was a problem hiding this comment.
But just to make sure, these objects were added by you with changeset 572d065 ...
(note to self: merge earlier to avoid such a mess :-) )
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.