Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pylint fixes #65

Merged
merged 3 commits into from
Apr 23, 2021
Merged

Pylint fixes #65

merged 3 commits into from
Apr 23, 2021

Conversation

palfrey
Copy link
Collaborator

@palfrey palfrey commented Apr 23, 2021

Also a minor travis.yml item and a tox warning fix

@@ -23,7 +23,6 @@ cache:
- $HOME/.cache/pip
language: python
script: travis_wait tox
after_success: coveralls
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate config from the bottom of the file

@@ -15,6 +15,7 @@ deps =
pydocstyle
pytest
pytest-cov
whitelist_externals = make
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stops tox complaining about make usage

@palfrey palfrey marked this pull request as ready for review April 23, 2021 17:16
@coveralls
Copy link

Coverage Status

Coverage remained the same at 81.603% when pulling a2b3024 on palfrey:pylint-fixes into bba55bb on Julius2342:master.

@palfrey
Copy link
Collaborator Author

palfrey commented Apr 23, 2021

https://travis-ci.org/github/Julius2342/pyvlx/builds/768129909 shows this build working, but the Travis check here appears to be missing.

@Julius2342 Julius2342 merged commit bb748d1 into Julius2342:master Apr 23, 2021
@Julius2342
Copy link
Owner

Thank you very much :)

@palfrey palfrey deleted the pylint-fixes branch April 23, 2021 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants