Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: German keyboard added #20

Merged
merged 9 commits into from
Jan 15, 2022
Merged

WIP: German keyboard added #20

merged 9 commits into from
Jan 15, 2022

Conversation

Moini
Copy link
Contributor

@Moini Moini commented Dec 29, 2021

  • Translated metadata to German
  • Fixed a couple English strings and two small syntax issues I stumbled upon
  • Tried adding a German keyboard, currently stuck at trying to make it work without having to use two keystrokes to type a single German letter ä, ö, ü or ß.
  • Also added the ß as an 'accent' type thing, for other languages

What I'd like help with:

  • A screenshot to check my layout.
  • A check whether I found all the places where I need to change / add code (I don't speak Java, nor have I ever done any Android app programming)
  • Trying to find a way to make it work with a single key swipe in German to get ä,ö,ü,ß, it would be so awkward otherwise.

Please have a look, @Julow ! Merci!

If it doesn't work out with the one-keyswipe thing, please pick what you need for the other solution.

@Moini Moini mentioned this pull request Dec 29, 2021
@Julow Julow added this to the 1.11.0 milestone Dec 31, 2021
Copy link
Owner

@Julow Julow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, thanks !

srcs/juloo.keyboard2/KeyValue.java Outdated Show resolved Hide resolved
srcs/juloo.keyboard2/KeyValue.java Outdated Show resolved Hide resolved
res/xml/method.xml Outdated Show resolved Hide resolved
@@ -0,0 +1,6 @@
Alle benötigten Buchstaben und Zeichen sind von einer einzigen Ansicht aus erreichbar. Strg, Alt, Escape und viele weitere stehen ebenfalls zur Verfügung.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nice, thanks! However, I won't be able to maintain these (I'll improve the full_description soon and there's new changelogs to write all the time).
Would it make sense to not translate the changelogs and the full description (German readers will see them in english) to be sure they are uptodate ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was unsure about the changelog, but if it's not too much, I thought I could keep things up-to-date.

res/xml/qwertz.xml Outdated Show resolved Hide resolved
res/xml/qwertz.xml Show resolved Hide resolved
res/xml/qwertz.xml Outdated Show resolved Hide resolved
res/xml/qwertz.xml Outdated Show resolved Hide resolved
@Julow
Copy link
Owner

Julow commented Dec 31, 2021

I've made some changes upstream so I pushed a merge commit to your branch to fix the conflicts.

That's how the new layout looks currently:
image

res/xml/method.xml Outdated Show resolved Hide resolved
@Julow
Copy link
Owner

Julow commented Jan 9, 2022

I've added the support for the German language and for the ß in 93e84ba and I've also picked your commit about strings 4b43645. I've pushed an other merge commit to your branch.

Some tweaks are still needed before we can merge the new layout :)

About the translations, could you open a separate PR for them ? I plan to improve the english version first and I don't want to delay this PR more.

- Remove the ° key, it is already accessible with Fn+*.
- Remove the umlauts characters, they are accessible with the trema
  dead key, consistently to how it works in other languages.
- Tweak the definition for '?'.
@Julow
Copy link
Owner

Julow commented Jan 15, 2022

I've added a few tweaks to the keyboard:

  • Removed ° and fixed ?
  • Removed the umlauts characters, which are accessible with the ◌̈ dead key. This is consistent with how other languages are implemented.

Here's how it looks now:

image

I'm merging now to prepare for the release. Thanks a lot for your work !
Some parts of your initial PR were merged separately: 4b43645 93e84ba

@Julow Julow merged commit 133b6ec into Julow:master Jan 15, 2022
@Moini
Copy link
Contributor Author

Moini commented Jan 15, 2022

@Julow Thanks! When I understood that this keyboard project will not do what I was looking for, I lost interest. Sorry for not replying sooner.

@KloolK
Copy link

KloolK commented Jan 31, 2022

Hi @Julow, after reading through this and #4 I'm not sure why the german layout was implemented this way. As @Moini said, the Umlauts are very common in german and requiring two swipes for each is very cumbersome.

The screenshot shown here looks exactly like what I think we would need:
#20 (comment)

Why was this chosen instead?
#20 (comment)

@Julow
Copy link
Owner

Julow commented Jan 31, 2022

You are right, I wish to revert that. Are you interested in contributing the Umlauts back ? (and at the same time validate the qwertz layout)

The reason was to make the keyboard multi-language and focused on programming. But this is not reasonable on every layouts, I'll now make the distinction between the localized and the programming layouts.
The dead-key mechanism will be enforced only on programming layouts (only qwerty at the moment) and I'll accept new or modified layouts for every languages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants