-
-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: German keyboard added #20
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing, thanks !
@@ -0,0 +1,6 @@ | |||
Alle benötigten Buchstaben und Zeichen sind von einer einzigen Ansicht aus erreichbar. Strg, Alt, Escape und viele weitere stehen ebenfalls zur Verfügung. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is nice, thanks! However, I won't be able to maintain these (I'll improve the full_description
soon and there's new changelogs to write all the time).
Would it make sense to not translate the changelogs and the full description (German readers will see them in english) to be sure they are uptodate ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was unsure about the changelog, but if it's not too much, I thought I could keep things up-to-date.
Broken since merge
I've added the support for the German language and for the ß in 93e84ba and I've also picked your commit about strings 4b43645. I've pushed an other merge commit to your branch. Some tweaks are still needed before we can merge the new layout :) About the translations, could you open a separate PR for them ? I plan to improve the english version first and I don't want to delay this PR more. |
- Remove the ° key, it is already accessible with Fn+*. - Remove the umlauts characters, they are accessible with the trema dead key, consistently to how it works in other languages. - Tweak the definition for '?'.
I've added a few tweaks to the keyboard:
Here's how it looks now: I'm merging now to prepare for the release. Thanks a lot for your work ! |
@Julow Thanks! When I understood that this keyboard project will not do what I was looking for, I lost interest. Sorry for not replying sooner. |
Hi @Julow, after reading through this and #4 I'm not sure why the german layout was implemented this way. As @Moini said, the Umlauts are very common in german and requiring two swipes for each is very cumbersome. The screenshot shown here looks exactly like what I think we would need: Why was this chosen instead? |
You are right, I wish to revert that. Are you interested in contributing the Umlauts back ? (and at the same time validate the qwertz layout) The reason was to make the keyboard multi-language and focused on programming. But this is not reasonable on every layouts, I'll now make the distinction between the localized and the programming layouts. |
What I'd like help with:
Please have a look, @Julow ! Merci!
If it doesn't work out with the one-keyswipe thing, please pick what you need for the other solution.