Skip to content

Commit

Permalink
Use vm_name to delete the VM object
Browse files Browse the repository at this point in the history
Schema transformer was incorrecty using si_name to delete VM object. It should
use vm_name. Because of this, stale VM objects remain in schema transformer
local memory and so, if SI is created again, it thinks the VM exists but no VMIs
exist and hence service chain is not created.

This is partial fix because we still do not break service chain when SI is deleted.

Change-Id: I4458352e3af0feeb1f68c57920b6875991cfac81
Partial-Bug: 1499125
  • Loading branch information
Sachin Bansal committed Sep 24, 2015
1 parent cffabee commit b5fe2fa
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/config/schema-transformer/to_bgp.py
Original file line number Diff line number Diff line change
Expand Up @@ -3139,7 +3139,7 @@ def add_virtual_machine_service_instance(self, idents, meta):
def delete_virtual_machine_service_instance(self, idents, meta):
vm_name = idents['virtual-machine']
si_name = idents['service-instance']
vm = VirtualMachineST.delete(si_name)
vm = VirtualMachineST.delete(vm_name)
for sc in ServiceChain._dict.values():
if si_name in sc.service_list:
if VirtualNetworkST.get(sc.left_vn) is not None:
Expand Down

0 comments on commit b5fe2fa

Please sign in to comment.